Notes: idpy Dev call, 20 February 2018
Ivan, Heather, Scott, John
* Heather to work with Ivan to create a shared admin account to manage
mailing list, slack, other tools as needed
* Heather to create templates for PRs and Issues
* Heather to add notes as needed to the PRs from today’s call
* Scott will re-run the tests for pyFF PR 118; if the test is actually
broken, Scott will write up an issue that there is a bad test.
0. Agenda bash
Set up an admin account to manage mailing list and slack.
1. Establishing a PR template -
* Do we want to have a similar template for issues?
Yes, we want templates for both.
Two sections for a PR template: what problem are you trying to solve,
and what the solution is and why that solution and not something else
For issues: Include a pointer to documentation, what version is being
used, what branch are you using
2. Satosa pull requests (no more than 10 minutes each) -
- #172 - fairly self contained. Ivan has’t tested the code yet. He
will do that, and assuming the code passes tests, will merge it. Scott
notes that the code is being used in production on a particular project
off a different branch.
- #137 - from Ivan’s email "needs to be refactored - part of it is
already there, part of it is useful, part of it belongs to pysaml2”.
Some of this needs to move to pySAML, and other changes are already made
by other commits. What’s missing is what the title says: adding the
nameID format. That’s easy to do, and something Ivan can do fairly
easily. There is a checkbox when you create a pull request that would
allow the project developer to change the commit. That was set for this,
so Ivan will directly edit the pull request.
- #166 - Ivan would like to reproduce this to figure out what
exactly is the problem. What is being done in the PR is capture every
exception and presenting an error, which might not be the best path
forward. This is not a fix, just a presentation of errors. Ask Rainer to
create a test for this issue so we can understand the full failure mode.
John adding that as a comment to the PR, Scott will add a request for
clarification to the Issue.
- #171 - Ivan has to review this one in more detail. This one could
very much use the template to explain what and why this PR exists. There
is no description around how this works or why it’s built this way.
3. pySAML2 - still needs to move to the IdentityPython repository
- #483 Enable signature verification for MDQ - This seems to be
fine. It does what it needs to do. It is related to Issue 448. Scott
will be writing some tests. When that is done, this and 485 can be merged.
- #485 Add want_assertions_or_response_signed functionality - Ivan
still needs to review this one. Scott reports this one is problematic -
this is the only way Scott can see to make this happen given how the
code is currently structured. It is ugly, but no obvious other way to do
it without a heavy refactor or the the pySAML code base. Scott will be
writing tests on this one (priority over 483)
pyFF: Failure of Travis CI build - what do we need to do about this
error? Someone needs to go back and review/fix the test that is causing
this to fail. Fixing the test should be a separate pull request. Scott
will re-run the tests for pyFF PR 118; if the test is actually broken,
Scott will write up an issue that there is a bad test.