4:18 p.m.
Attendees: Martin, Heather
No word from Ivan, so not sure about the status of today’s call
https://github.com/IdentityPython/satosa_microservices/pull/11
Martin made a minor pull request around consent service (microservice). To really fix the
problem Satosa has to be changed to accept HTTPS POST requests. Not sure if/how this is
handled by idpy.
If you update this microservice without Satosa being changed, then Satosa will break. This
is not a backwards compatible change.
Any issues with the template for the PR? It was a bit heavier weight than was necessary
for such a small change, a bug fix. This was also already fixed in SURF’s own branch, so
they’ve already got it running.
Sent from my iPad
4:39 p.m.
Just a minor correction to the state of affairs:
The CMService PR is backwards compatible, it only introduces a new request
type POST, but still supports original GET. The Satosa PR otoh breaks consent
if CMservice isn't updated as well.
So: CMservice PR is safe, Satosa PR needs CMservice PR.
Best regards,
Martin
On Tuesday, May 15, 2018 3:18:29 PM CEST Heather Flanagan wrote:
Attendees: Martin, Heather
No word from Ivan, so not sure about the status of today’s call
https://github.com/IdentityPython/satosa_microservices/pull/11
Martin made a minor pull request around consent service (microservice). To
really fix the problem Satosa has to be changed to accept HTTPS POST
requests. Not sure if/how this is handled by idpy.
If you update this microservice without Satosa being changed, then Satosa
will break. This is not a backwards compatible change.
Any issues with the template for the PR? It was a bit heavier weight than
was necessary for such a small change, a bug fix. This was also already
fixed in SURF’s own branch, so they’ve already got it running.
Sent from my iPad
4:42 p.m.
On May 15, 2018, at 06:39, Martin van Es <martin at
surfnet.nl> wrote:
Just a minor correction to the state of affairs:
The CMService PR is backwards compatible, it only introduces a new request
type POST, but still supports original GET. The Satosa PR otoh breaks consent
if CMservice isn't updated as well.
So: CMservice PR is safe, Satosa PR needs CMservice PR.
Thanks for the correction, Martin!
Sent from my iPad
Best regards,
Martin
On Tuesday, May 15, 2018 3:18:29 PM CEST Heather
Flanagan wrote:
Attendees: Martin, Heather
No word from Ivan, so not sure about the status of today’s call
https://github.com/IdentityPython/satosa_microservices/pull/11
Martin made a minor pull request around consent service (microservice). To
really fix the problem Satosa has to be changed to accept HTTPS POST
requests. Not sure if/how this is handled by idpy.
If you update this microservice without Satosa being changed, then Satosa
will break. This is not a backwards compatible change.
Any issues with the template for the PR? It was a bit heavier weight than
was necessary for such a small change, a bug fix. This was also already
fixed in SURF’s own branch, so they’ve already got it running.
Sent from my iPad
2:40 p.m.
Hello,
On 15 May 2018 at 16:39, Martin van Es <martin at surfnet.nl> wrote:
Just a minor correction to the state of affairs:
The CMService PR is backwards compatible, it only introduces a new request
type POST, but still supports original GET. The Satosa PR otoh breaks consent
if CMservice isn't updated as well.
So: CMservice PR is safe, Satosa PR needs CMservice PR.
Yep, got it ;)
We can change this to be configurable, in order to keep the old
behaviour. When we set the consent microservice in "POST mode" we do
the new handling.
Other than that, the GET request can still work by configuring your
frontend webserver appropriately - ie, nginx allows one to set the
'large_client_header_buffers' in order to accept the set amount of
data through a GET request (that is through the URI / the 'buffer'
limits the size of the URI).
We can probably discuss more on the PR itself.
On Tuesday, May 15, 2018 3:18:29 PM CEST Heather Flanagan wrote:
> Attendees: Martin, Heather
>
> No word from Ivan, so not sure about the status of today’s call
>
I am very sorry about that - I was busy and missed the call and your email.
Cheers,
--
Ivan c00kiemon5ter Kanakarakis >:3
2410
days inactive
2412
days old
3 comments
3 participants
participants (3)
-
hlflanagan＠sphericalcowgroup.com -
ivan.kanak＠gmail.com -
martin＠surfnet.nl