Cheers,
Niels
On 23-02-17 16:21, Ioannis Kakavas wrote:
Sorry for the double mail, getting a bit mentally
exhausted after
TIIME. We should probably figure out a way to differentiate
discussions/feedback etc between satosa as a project and products that
use satosa (inAcademia).
This discussion for example started from a request that Lukas made for
inAcademia and the UI changes (colors etc)are specific to inAcademia
so its probably not very relevant for satosa-dev.
Maybe what could be of interest for that list/community would be a
discuss on how to make the UI of the consent module based on ie
Bootstrap and make it easy to have "themes" (inAcademia theme, etc) .
I will create an enhancement issue on github once the consent module
has been moved to satosa-contrib and we can discuss if it's worth
looking into it.
Best
Ioannis
Sent from BlueMail <http://www.bluemail.me/r?b=8872>
------------------------------------------------------------------------
*From:* Ioannis Kakavas
*Sent:* Thu Feb 23 16:05:42 GMT+01:00 2017
*To:* Stavros 0 Sachtouris
*Cc:* Niels van Dijk , "Lukas Hämmerle"
*Subject:* Re: First SaToSa change
The idea is to move all related software (microservices mostly) to a
satosa-contrib repository so that will mitigate that concern.
Ioannis
Sent from BlueMail <http://www.bluemail.me/r?b=8872>
------------------------------------------------------------------------
*From:* Stavros 0 Sachtouris
*Sent:* Thu Feb 23 14:32:48 GMT+01:00 2017
*To:* Niels van Dijk , "Lukas Hämmerle" , Ioannis Kakavas
*Subject:* Re: First SaToSa change
Hi Niels,
in this particular case, the consent module is not a part of the
SAtoSA github repository. My concern is that, if people follow the
SAtoSA repository, will they be notified about changes happening in
other related repositories if they are not notified through the list?
Stavros
On 02/23/2017 11:50 AM, Niels van Dijk wrote:
> Hi Stavros,
>
> Yesterday at the TIIME meeting we have a meeting with various teams that
> work with SaToSa (SUnet, GEANT, SCG). We agreed that the satosa github
> issues tracker for requesting feedback, putting in new feature requests,
> and that pull requests is indeed the right way to go as well for
> proposing software changes.
>
> Cheers,
>
> Niels
>
>
> On 23-02-17 10:33, Stavros 0 Sachtouris wrote:
>> Hi Lukas,
>>
>> thank you for the feedback, I will drop the pull request and update
>> the patch with those of your observations that are not subject of
>> further discussion.
>>
>> Just one question: what is the right list to ask for feedback?
>>
>> Stavros
>>
>> On 02/23/2017 09:49 AM, Lukas Hämmerle wrote:
>>> Hi Stavros
>>>
>>> Great, this looks already a lot better than the current consent screen :-)
>>>
>>> A few quic comments/suggestions:
>>> * In the mobile version, the language selection is a bit too close to
>>> the InAcademia logo. Some space could help there. Even better, like in
>>> the desktop version you might want to reduce the width of the drop-down
>>> list as its (short) content is in no relation to its with currently.
>>> * typo: "Click to see what else is sent with your consent" (you
instead
>>> of your)
>>> * Personally, for InAcademia I would not leave the user the confusing
>>> option to define for how long the consent should be given. Instead I
>>> would just set a default of 3 months and add a note "Your consent
>>> decision is stored for 3 months" but that isYesterday at the TIIME
meeting we have a meeting with various teams that
>>> work with SaToSa (SUnet, GEANT, SCG). We agreed that the satosa github
>>> issues tracker for requesting feedback, putting in new feature requests,
>>> and that pull requests is indeed the right way to go as well for
>>> proposing software changes. probably something to discuss
>>> * I would use the same font size for the attribute name and value. Too
>>> many font-sizes are confusing.
>>> * Instead of:
>>> ----------------------------------------------------------------
>>> Given name
>>> ✓ ['Stavros']
>>> ----------------------------------------------------------------
>>> How about much simpler and space-saving
>>> ----------------------------------------------------------------
>>> Given name Stavros
>>> ----------------------------------------------------------------
>>> * Personally I would switch the positions of the OK and No buttons and
>>> align them right.
>>>
>>>
>>> On 22.02.17 15:11, Stavros 0 Sachtouris wrote:
>>>> Should I forward this to one of the lists as well?
>>> Yes, that probably would help getting more feedback on UI aspects.
>>>
>>> Best Regards
>>> Lukas
>>>
>>>
>>>
--
Niels van Dijk Technical Product Manager Trust & Security
Mob: +31 651347657 | Skype: cdr-80 | PGP Key ID: 0xDE7BB2F5
SURFnet BV | PO.Box 19035 | NL-3501 DA Utrecht | The Netherlands
www.surfnet.nl www.openconext.org